ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jayush Luniya" <jlun...@hortonworks.com>
Subject Re: Review Request 33462: AMBARI-10676: Patch for implementing DB connectivity
Date Thu, 23 Apr 2015 06:40:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33462/#review81276
-----------------------------------------------------------


Based on what I see in this patch, it looks like DB connection check is run during  install/start
execution. We should be validating this at "Customize Services" step before starting the deployment.
Take a look at how this is done for Hive/Oozie. If you select one of the "Existing MySQL Database"
type, you will see that it displays "Test Connection" button which if click invokes a check_host
command with check_execute_list":"db_connection_check" to validate the DB connection properties.
We should do similar changes for RANGER.

- Jayush Luniya


On April 23, 2015, 1:30 a.m., Velmurugan Periasamy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33462/
> -----------------------------------------------------------
> 
> (Updated April 23, 2015, 1:30 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Jayush
Luniya, Mahadev Konar, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-10676
>     https://issues.apache.org/jira/browse/AMBARI-10676
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Logic for DB connection test
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml
aefb200 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
e2b8ba8 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py
391df2a 
> 
> Diff: https://reviews.apache.org/r/33462/diff/
> 
> 
> Testing
> -------
> 
> -- tested functionality locally
> -- verified python unit tests 
> 
> -----------------------------------------------------------------------
> Ran 232 tests in 6.758s
> 
> OK
> ----------------------------------------------------------------------
> Total run:675
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Velmurugan Periasamy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message