ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 33454: RU Finalization Should Set The Correct Stack Versions On Upgrade
Date Wed, 22 Apr 2015 22:33:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33454/#review81230
-----------------------------------------------------------

Ship it!



ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
<https://reviews.apache.org/r/33454/#comment131482>

    Extra apostrophe


- Alejandro Fernandez


On April 22, 2015, 10:01 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33454/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 10:01 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-10673
>     https://issues.apache.org/jira/browse/AMBARI-10673
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari 2.0 upgrades were only within the stack, for example 2.2.0.0 -> 2.2.2.0.  
> 
> When applying an upgrade pack across stacks, for example HDP-2.2 -> HDP-2.3, the finalization
step must handle moving the cluster's current stack version as well as specific component
versions.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceConfigVersionResponse.java
486d349 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
88b9415 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java
aa4087d 
>   ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
7a8c4b9 
>   ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
b09a273 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
472953c 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 847e349 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java ff11e70

>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
6055eb8 
>   ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java
b44ac30 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
7d1f920 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
e076d4e 
> 
> Diff: https://reviews.apache.org/r/33454/diff/
> 
> 
> Testing
> -------
> 
> Manual testing of a 2.2 to 2.3 upgrade, watching the database to verify correct fields.
Verified with service_config_version endpoints after the upgrade that things looked good.
> 
> Added new tests to cover the upgrade across stacks.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message