ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Re: Review Request 33064: AMBARI-9993 Add support for management of Phoenix Query Server to HDP Stack
Date Tue, 21 Apr 2015 15:36:26 GMT


> On April 21, 2015, 11:51 a.m., Andrew Onischuk wrote:
> > I agree very much we need to merge metainfo not duplicate this is very very bad
change which leads to huge maintanance overhead.
> 
> Andrew Onischuk wrote:
>     The thing we should have been done is to override the components list in HDP-2.3
in metainfo but not duplicate the whole code. Jayush I'll create a ticket making this refactoring.
> 
> nick dimiduk wrote:
>     Thanks for having a look Andrew. Given the inheritance model, the inability to explicitly
import code from existing modules, and my need to define a new component of the service, it
seemed forking was the only way to go. If you have a means that reduces duplication, I'm all
ears :)

Hey Nick, 

We have examples where component where added only to some stacks. Like ATS for YARN which
is 2.1 stack but not in 2.0. 
We have a big inheritance thing around metainfo.xml and configurations for cases like this.
We had to put the code to the same folder, but override the components list in metainfo.xml
only for HDP-2.3 (not for common-services). In that case PHEONIX would be only visible in
2.3 and above stacks.

Anyway if you don't mind I've filed a ticket for this, and let's see if we can do a bit of
refactoring. Thanks


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33064/#review80950
-----------------------------------------------------------


On April 15, 2015, 7:37 p.m., nick dimiduk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33064/
> -----------------------------------------------------------
> 
> (Updated April 15, 2015, 7:37 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Yusaku Sako.
> 
> 
> Bugs: AMBARI-9993
>     https://issues.apache.org/jira/browse/AMBARI-9993
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Per JIRA
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/alerts.json PRE-CREATION

>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-env.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-log4j.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-policy.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-site.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/kerberos.json PRE-CREATION

>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/metainfo.xml PRE-CREATION

>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/metrics.json PRE-CREATION

>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/files/draining_servers.rb
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/files/hbaseSmokeVerify.sh
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/__init__.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/functions.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_client.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_decommission.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_master.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_regionserver.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_service.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_upgrade.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_linux.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_windows.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/phoenix_queryserver.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/phoenix_service.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/service_check.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/setup_ranger_hbase.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/status_params.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/upgrade.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase-smoke.sh.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_client_jaas.conf.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_grant_permissions.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_master_jaas.conf.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_regionserver_jaas.conf.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/regionservers.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/widgets.json PRE-CREATION

>   ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_client.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_master.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_regionserver.py PRE-CREATION

>   ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_service_check.py PRE-CREATION

>   ambari-server/src/test/python/stacks/2.3/HBASE/test_phoenix_queryserver.py PRE-CREATION

>   ambari-server/src/test/python/stacks/2.3/configs/default.hbasedecom.json PRE-CREATION

>   ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33064/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> nick dimiduk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message