ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "nick dimiduk" <ndimi...@gmail.com>
Subject Re: Review Request 33379: AMBARI-9993 addendum
Date Tue, 21 Apr 2015 02:01:02 GMT


> On April 20, 2015, 6:39 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/metainfo.xml, line
23
> > <https://reviews.apache.org/r/33379/diff/1/?file=937098#file937098line23>
> >
> >     Why did this have to change? Seems like all other services in HDP 2.3 don't
have the "common-services/$name" portion.
> 
> nick dimiduk wrote:
>     hmm. i thought it was necissary to be explicit about it. let me try without it.
> 
> nick dimiduk wrote:
>     Oh, this is an extends clause, not a veriion cluse. It needs both?

Okay, this is modeled after stack inhertiance patterns i've seen elsewhere, such as https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/metainfo.xml


- nick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33379/#review80874
-----------------------------------------------------------


On April 20, 2015, 6:41 p.m., nick dimiduk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33379/
> -----------------------------------------------------------
> 
> (Updated April 20, 2015, 6:41 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Yusaku Sako.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> addendum patch to AMBARI-9993. Copies over additional config files and adds user and
environment to command execution
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/metainfo.xml b3ebe60

>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/phoenix_queryserver.py
3ba5f7f 
>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/phoenix_service.py
f35b9a0 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/hbase-env.xml
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-plugin-properties.xml
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/metainfo.xml a254e9d

> 
> Diff: https://reviews.apache.org/r/33379/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> nick dimiduk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message