ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 33344: Expose A Way To Register Custom Alert Dispatchers
Date Mon, 20 Apr 2015 14:07:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33344/#review80717
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On April 20, 2015, 3:03 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33344/
> -----------------------------------------------------------
> 
> (Updated April 20, 2015, 3:03 a.m.)
> 
> 
> Review request for Ambari, Nate Cole and Tom Beerbower.
> 
> 
> Bugs: AMBARI-10590
>     https://issues.apache.org/jira/browse/AMBARI-10590
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There are currently 2 tightly coupled dispatchers that ship with Ambari: EMAIL and SNMP.
In the event that a user would like to register their own dispatcher after installing Ambari,
we should expose a way for them to register that dispatcher with Ambari Server so that they
can create alert targets for the dispatcher's type.
> 
> - Custom dispatchers will need to be picked up from the classpath dynamically at runtime
and registered
> - A new state needs to be added to Alert Notices to indicate that they have been processed
in the event that a dispatcher does not set the final delivery state on the notice
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
36ae66b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
f341db0 
>   ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java
2675533 
>   ambari-server/src/main/java/org/apache/ambari/server/notifications/Notification.java
12dffd7 
>   ambari-server/src/main/java/org/apache/ambari/server/notifications/NotificationDispatcher.java
19d813f 
>   ambari-server/src/main/java/org/apache/ambari/server/notifications/TargetConfigurationResult.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java
4761370 
>   ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
e0751bf 
>   ambari-server/src/main/java/org/apache/ambari/server/state/NotificationState.java ef69deb

>   ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java
974dcdf 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java
40d2241 
>   ambari-server/src/test/java/org/apache/ambari/server/notifications/DispatchFactoryTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/notifications/MockDispatcher.java
ae73b51 
>   ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcherTest.java
919d747 
>   ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java
07ca3ae 
>   ambari-server/src/test/java/org/apache/ambari/server/state/services/AlertNoticeDispatchServiceTest.java
3f09db0 
> 
> Diff: https://reviews.apache.org/r/33344/diff/
> 
> 
> Testing
> -------
> 
> Manual testing of a custom NOOP dispatcher to verify that notices are moved into the
DISPATCHED state after being processed.
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message