ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 33264: AMBARI-10523 : Add support of Ranger KMS to Ambari
Date Sun, 19 Apr 2015 00:01:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33264/#review80621
-----------------------------------------------------------


Overall, this is pretty good.


ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/metainfo.xml
<https://reviews.apache.org/r/33264/#comment130723>

    Is there a corresponding component in hdp-select for this? If yes, then versionAdvertised
= true confirms this.



ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
<https://reviews.apache.org/r/33264/#comment130724>

    We should use named imports since it makes it easier to find where libs come from.



ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py
<https://reviews.apache.org/r/33264/#comment130725>

    How will this component be updated during a Rolling Upgrade? If it already has a component
in hdp-select, then we need to call "hdp-select set <component_name> <version>"
here. See other components for reference. Also, it will need to be added to the upgrade pack,
upgrade-2.3.xml



ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py
<https://reviews.apache.org/r/33264/#comment130726>

    Use named imports.



ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py
<https://reviews.apache.org/r/33264/#comment130727>

    Is it safer to first do a kill -15. May want to try using shell.kill_process_with_children(...)



ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
<https://reviews.apache.org/r/33264/#comment130729>

    Just check if > 0



ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/service_check.py
<https://reviews.apache.org/r/33264/#comment130730>

    Use named imports, looks like only Logger, shell, and ComponentIsNotRunning are needed.


- Alejandro Fernandez


On April 16, 2015, 3:10 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33264/
> -----------------------------------------------------------
> 
> (Updated April 16, 2015, 3:10 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, Sumit Mohanty, and
Yusaku Sako.
> 
> 
> Bugs: AMBARI-10523
>     https://issues.apache.org/jira/browse/AMBARI-10523
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ranger KMS should be available as a service to be installed/managed from Ambari.
> User will be able to add a new service "Ranger KMS" and there will be one Server component
in the service.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/alerts.json PRE-CREATION

>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-acls.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-log4j.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-properties.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/metainfo.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/service_check.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json ead3dd4 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER_KMS/metainfo.xml PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/33264/diff/
> 
> 
> Testing
> -------
> 
> Tested adding the Ranger KMS on an CentOS6 instance.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message