ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yusaku Sako" <yus...@hortonworks.com>
Subject Re: Review Request 33269: Integrate displaying defined Number widget type from the API on service summary page
Date Thu, 16 Apr 2015 20:13:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33269/#review80372
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On April 16, 2015, 7:55 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33269/
> -----------------------------------------------------------
> 
> (Updated April 16, 2015, 7:55 p.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-10547
>     https://issues.apache.org/jira/browse/AMBARI-10547
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Integrate displaying defined Number widget type from the API on service summary page
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metrics.json 627667b

>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/widgets.json ece1b03

>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/metrics.json 7bbf7be

>   ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/widgets.json a64a2c8

>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/widgets.json PRE-CREATION

>   ambari-web/app/assets/data/widget_layouts/HBASE/default_dashboard.json 0636541 
>   ambari-web/app/config.js 140e7c3 
>   ambari-web/app/controllers/main/service/info/summary.js 5a37bc3 
>   ambari-web/app/mappers/stack_service_mapper.js 612c62e 
>   ambari-web/app/mappers/widget_layout_mapper.js d46099d 
>   ambari-web/app/mappers/widget_mapper.js c9b1aef 
>   ambari-web/app/mixins/common/widget_mixin.js 48fbf8f 
>   ambari-web/app/models/widget.js 6147bf5 
>   ambari-web/app/models/widget_layout.js 2c29670 
>   ambari-web/app/templates/main/service/info/summary.hbs 81e1e6d 
>   ambari-web/app/utils/ajax/ajax.js e7d28bc 
>   ambari-web/app/views/common/widget/graph_widget_view.js e886b9b 
>   ambari-web/app/views/main/service/info/summary.js af3e359 
>   ambari-web/test/controllers/main/service/info/summary_test.js 8ce848c 
>   ambari-web/test/mappers/stack_service_mapper_test.js 1b6ccfa 
>   ambari-web/test/mixins/common/widget_mixin_test.js edb5359 
> 
> Diff: https://reviews.apache.org/r/33269/diff/
> 
> 
> Testing
> -------
> 
> tested on a cluster.
> Edited and added unit test.
> verified that all unit test passes.
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message