ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Review Request 33172: UPGRADE: Due to changes in Ambari API some response validations should be allowed with warning message
Date Tue, 14 Apr 2015 15:18:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33172/
-----------------------------------------------------------

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: branch-2.0.maint
    https://issues.apache.org/jira/browse/branch-2.0.maint


Repository: ambari


Description
-------

upgradeHelper use well old realization of curl via shell execute. And to handle response errors
use some kind of validation of response. For new releases of Ambari response content could
be changed from time to time. We need to add some "soft" validation without generation error
and just warn user about unexpected response.


Diffs
-----

  ambari-server/src/main/python/upgradeHelper.py 11292e9 
  ambari-server/src/test/python/TestUpgradeHelper.py 2f47620 

Diff: https://reviews.apache.org/r/33172/diff/


Testing
-------

----------------------------------------------------------------------
Ran 262 tests in 6.250s

OK
----------------------------------------------------------------------
Total run:641
Total errors:0
Total failures:0
OK


Thanks,

Dmitro Lisnichenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message