ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 33169: UPGRADE: Due to changes in Ambari API some response validations should be allowed with warning message
Date Tue, 14 Apr 2015 15:01:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33169/
-----------------------------------------------------------

(Updated April 14, 2015, 3:01 p.m.)


Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-10467
    https://issues.apache.org/jira/browse/AMBARI-10467


Repository: ambari


Description
-------

upgradeHelper use well old realization of curl via shell execute. And to handle response errors
use some kind of validation of response. For new releases of Ambari response content could
be changed from time to time. We need to add some "soft" validation without generation error
and just warn user about unexpected response.


Diffs
-----

  ambari-server/src/main/python/upgradeHelper.py 95d663a 
  ambari-server/src/test/python/TestUpgradeHelper.py 09dc360 

Diff: https://reviews.apache.org/r/33169/diff/


Testing
-------

----------------------------------------------------------------------
Ran 263 tests in 6.244s

OK
----------------------------------------------------------------------
Total run:673
Total errors:0
Total failures:0
OK

Process finished with exit code 0


Thanks,

Dmitro Lisnichenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message