ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srimanth Gunturi" <srima...@hortonworks.com>
Subject Re: Review Request 33056: Display service specific Heatmap in the respective service page
Date Sat, 11 Apr 2015 00:14:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33056/#review79788
-----------------------------------------------------------

Ship it!


Ship It!

- Srimanth Gunturi


On April 10, 2015, 9:58 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33056/
> -----------------------------------------------------------
> 
> (Updated April 10, 2015, 9:58 p.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-10427
>     https://issues.apache.org/jira/browse/AMBARI-10427
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> As part of this ticket service specific heatmap will be shown in their respective page
with a new tab "Heatmaps". (The screenshot is attached on the Jira. Also the work can be seen
on the brunch server with mock data). Dashboard->Heatmaps will show system metrics heatmap
> Apart from this, spinner has been changed to be shown next to the Label of the heatmap
rather than individual div element. Later makes the page go up and down when the spinner is
shown/hidden.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json 23f65f2 
>   ambari-web/app/controllers.js 816dbf5 
>   ambari-web/app/controllers/main/charts/heatmap.js ecc57b3 
>   ambari-web/app/controllers/main/service/info/heatmap.js PRE-CREATION 
>   ambari-web/app/messages.js 4d7a811 
>   ambari-web/app/models/stack_service.js 39995bb 
>   ambari-web/app/routes/main.js 5083549 
>   ambari-web/app/styles/application.less d4725f1 
>   ambari-web/app/templates/main/charts/heatmap.hbs e1942bd 
>   ambari-web/app/templates/main/service/item.hbs eed34f2 
>   ambari-web/app/views.js 936b2d3 
>   ambari-web/app/views/main/charts/heatmap.js 59b36ff 
>   ambari-web/app/views/main/charts/heatmap/heatmap_rack.js 11c4f64 
>   ambari-web/app/views/main/service/info/heatmap_view.js PRE-CREATION 
>   ambari-web/app/views/main/service/info/menu.js bdb0e1d 
>   ambari-web/app/views/main/service/item.js db2b490 
> 
> Diff: https://reviews.apache.org/r/33056/diff/
> 
> 
> Testing
> -------
> 
> Tested on a live cluster, brunch server.
> Verified that ambari-web unit tests passes successfully with the patch
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message