ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Sen" <d...@hortonworks.com>
Subject Re: Review Request 33077: Set default cardinality for ComponentInfo if not specified in metainfo.xml
Date Fri, 10 Apr 2015 21:44:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33077/
-----------------------------------------------------------

(Updated Апрель 10, 2015, 9:44 п.п.)


Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.


Bugs: AMBARI-10435
    https://issues.apache.org/jira/browse/AMBARI-10435


Repository: ambari


Description
-------

No cardinality specified in metainfo.xml for HCAT component. Possibly for some another components
either.
It's better to set cardinallity to some default value like "0+" insteand of null, which could
lead to NPE


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 624227e 
  ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java 42d6944

  ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java 1ae4cd1


Diff: https://reviews.apache.org/r/33077/diff/


Testing (updated)
-------

[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ....................................... SUCCESS [4.028s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.051s]
[INFO] Ambari Web ........................................ SUCCESS [37.284s]
[INFO] Ambari Views ...................................... SUCCESS [2.726s]
[INFO] Ambari Admin View ................................. SUCCESS [10.754s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.679s]
[INFO] Ambari Server ..................................... SUCCESS [1:20:01.930s]
[INFO] Ambari Agent ...................................... SUCCESS [9.098s]
[INFO] Ambari Client ..................................... SUCCESS [0.055s]
[INFO] Ambari Python Client .............................. SUCCESS [1.786s]
[INFO] Ambari Groovy Client .............................. SUCCESS [11.065s]
[INFO] Ambari Shell ...................................... SUCCESS [0.031s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.040s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [7.028s]


Thanks,

Dmytro Sen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message