ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 33075: RU Improvements. Part 1
Date Fri, 10 Apr 2015 17:39:11 GMT


> On April 10, 2015, 5:14 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java,
line 337
> > <https://reviews.apache.org/r/33075/diff/3/?file=923124#file923124line337>
> >
> >     Do we need to make any null or empty checks first?

I can't imagine the situation when we get null while listing services in cluster or components
of service. Empty list is well-treated by java foreach loop if I understand the question right.


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33075/#review79699
-----------------------------------------------------------


On April 10, 2015, 2:16 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33075/
> -----------------------------------------------------------
> 
> (Updated April 10, 2015, 2:16 p.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-10432
>     https://issues.apache.org/jira/browse/AMBARI-10432
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Part 1
> - Important: Before running HDFS Finalize, run a Server Action, similar to FinalizeUpgradeAction,
that will confirm that all host components have been upgraded to the version. This action
is to inform the user, so it may fail and the user can skip. [Update] Just modify FinalizeUpgradeAction
to do this work.
> - /api/v1/clusters/c1/hosts/host_name/host_components/component_name to show the current
version field
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
ab5c31c 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
01bd9c7 
>   ambari-server/src/main/resources/properties.json 540d58b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java
9bc7570 
> 
> Diff: https://reviews.apache.org/r/33075/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message