ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jayush Luniya" <jlun...@hortonworks.com>
Subject Re: Review Request 33080: [WinTP2] Merge HDPWIN YARN package scripts into common services
Date Fri, 10 Apr 2015 17:31:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33080/#review79706
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
<https://reviews.apache.org/r/33080/#comment129236>

    Ideally I would also add an action="status" to service and then refactor status to base
class which would call 
    service('nodemanager', action='status')
    
    You just need to make sure though for action=status you import status_params instead of
params.



ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
<https://reviews.apache.org/r/33080/#comment129231>

    Combine the 2 if-else in single if statement as action=action can be used.



ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
<https://reviews.apache.org/r/33080/#comment129233>

    If we had the service names as a map of component to service name we could have simply
done
    
    service_name = params.service_map[component] 
    Service(service_name, action=action)


- Jayush Luniya


On April 10, 2015, 2:49 p.m., Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33080/
> -----------------------------------------------------------
> 
> (Updated April 10, 2015, 2:49 p.m.)
> 
> 
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
> 
> 
> Bugs: AMBARI-10439
>     https://issues.apache.org/jira/browse/AMBARI-10439
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> [WinTP2] Merge HDPWIN YARN package scripts into common services
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
184596c 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
9a43efa 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py
4ee1839 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
1f2046a 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
af48969 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params.py
871162a 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_windows.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
e0f3b65 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
1002094 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
42b113a 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/status_params.py
5ed99fd 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
5372d24 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py
8f76394 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/package/scripts/application_timeline_server.py
09a8f6d 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/package/scripts/historyserver.py
969963d 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/package/scripts/mapred_service_check.py
82bb0fc 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/package/scripts/mapreduce2_client.py
d324e95 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/package/scripts/nodemanager.py
4b767b1 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/package/scripts/params.py
e48655d 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/package/scripts/resourcemanager.py
29e4efa 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/package/scripts/service_check.py
8196f2e 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/package/scripts/service_mapping.py
1863797 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/package/scripts/yarn.py
2783c13 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/package/scripts/yarn_client.py
b7037b6 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/package/templates/container-executor.cfg.j2
90b12e6 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/package/templates/exclude_hosts_list.j2
c7ce416 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/package/templates/mapreduce.conf.j2
b996645 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/package/templates/taskcontroller.cfg.j2
3d5f4f2 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/package/templates/yarn.conf.j2
3bd7a45 
> 
> Diff: https://reviews.apache.org/r/33080/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [5.215s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.814s]
> [INFO] Ambari Server ..................................... SUCCESS [1:21.311s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message