ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jayush Luniya" <jlun...@hortonworks.com>
Subject Re: Review Request 33031: [WinTP2] Merge HDPWIN HIVE package scripts to common services
Date Fri, 10 Apr 2015 17:10:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33031/#review79696
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat.py
<https://reviews.apache.org/r/33031/#comment129216>

    Shouldnt we be writting the hive-site.xml etc configs as well for Windows? I think hcat
wouldnt work if it is installed on a separate node without hive on it.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
<https://reviews.apache.org/r/33031/#comment129217>

    add hive_exclude_packages = [] in params_windows and move the install() code to base to
keep it identical.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py
<https://reviews.apache.org/r/33031/#comment129218>

    We need to add service check for Hcat. RunSmokeTests.ps1 has 
    function Run-HCatalogSmokeTest
    {
    }
    
    Run-SmokeTests.cmd HCatalog



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
<https://reviews.apache.org/r/33031/#comment129219>

    Add hive_exclude_packages = [] in params_windows and refactor.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
<https://reviews.apache.org/r/33031/#comment129220>

    Same here. Refactor with hive_exclude_packages = []



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
<https://reviews.apache.org/r/33031/#comment129221>

    Refactor here too.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
<https://reviews.apache.org/r/33031/#comment129222>

    Can do in a single if
    i.e.
    
    if action == "start" or action == "stop"
      Service(params.hive_metastore_win_service_name, action=action)



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
<https://reviews.apache.org/r/33031/#comment129223>

    Same here



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py
<https://reviews.apache.org/r/33031/#comment129225>

    Should MySQLServer even be a component for Windows? i.e. shouldnt we mark it as <deleted>true</deleted>
in HDPWIN/2.1/services/HIVE/metainfo.xml. that way we dont even need to refactor here.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
<https://reviews.apache.org/r/33031/#comment129226>

    Refactor


- Jayush Luniya


On April 9, 2015, 9:23 p.m., Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33031/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 9:23 p.m.)
> 
> 
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
> 
> 
> Bugs: AMBARI-10421
>     https://issues.apache.org/jira/browse/AMBARI-10421
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> [WinTP2] Merge HDPWIN HIVE package scripts to common services
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat.py
31c1673 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
811cac6 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py
fd4c6ca 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
07148d7 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
f8306da 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
8753133 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
0e03a22 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
bbd9dee 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py
dcfb567 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params.py
e4e52b8 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_windows.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/service_check.py
9f822a9 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
3b75b98 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
4f1d564 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
2b470a9 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py
d1251df 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
bea1f56 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/etc/hive-schema-0.12.0.mysql.sql
bacee9e 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/etc/hive-schema-0.12.0.oracle.sql
a2cbfa2 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/etc/hive-schema-0.12.0.postgres.sql
61769f6 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/hcat_client.py
33c1fdf 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/hcat_service_check.py
69535d5 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/hive.py
5f21170 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/hive_client.py
44fd342 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/hive_metastore.py
6772e8b 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/hive_server.py
f43084b 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/mysql_server.py
7fd06de 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/params.py
aa41e12 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/service_check.py
619be7a 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/service_mapping.py
84dd897 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/webhcat.py
91a33e4 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/webhcat_server.py
527efb8 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/webhcat_service_check.py
1fa08a3 
> 
> Diff: https://reviews.apache.org/r/33031/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [4.835s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.547s]
> [INFO] Ambari Server ..................................... SUCCESS [1:14.194s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message