ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Sen" <d...@hortonworks.com>
Subject Review Request 33077: Set default cardinality for ComponentInfo if not specified in metainfo.xml
Date Fri, 10 Apr 2015 12:58:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33077/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.


Bugs: AMBARI-10435
    https://issues.apache.org/jira/browse/AMBARI-10435


Repository: ambari


Description
-------

No cardinality specified in metainfo.xml for HCAT component. Possibly for some another components
either.
It's better to set cardinallity to some default value like "0+" insteand of null, which could
lead to NPE


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 624227e 

Diff: https://reviews.apache.org/r/33077/diff/


Testing
-------

unit tests passed


Thanks,

Dmytro Sen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message