ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Di Li" <d...@ca.ibm.com>
Subject Re: Review Request 32932: The stop service confirmation dialog should show a warning if some other services depends on the one to be stopped
Date Thu, 09 Apr 2015 18:37:13 GMT


> On April 8, 2015, 6:33 p.m., Alejandro Fernandez wrote:
> > ambari-web/app/messages.js, line 1723
> > <https://reviews.apache.org/r/32932/diff/1/?file=919630#file919630line1723>
> >
> >     Just use one message and label it as "service(s)"

Hello Alejandro,

please review the second diff attached, it has the update requested -- using one message lable
as "service(s)" and the corresponding JS code change.


- Di


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32932/#review79391
-----------------------------------------------------------


On April 8, 2015, 7:54 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32932/
> -----------------------------------------------------------
> 
> (Updated April 8, 2015, 7:54 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-10333
>     https://issues.apache.org/jira/browse/AMBARI-10333
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The stop service confirmation dialog should show a warning if some other services depends
on the service to be stopped, so that the user is warned about the other services may not
function properly after the selected service is stopped. For example, stopping HDFS would
bring up a warning saying the HBase depends on HDFS. User then has the option to either Cancel
the operation or click Confirm Stop to continue.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/item.js 8f817d2 
>   ambari-web/app/messages.js 6feaf0b 
>   ambari-web/test/controllers/main/service/item_test.js 7d57570 
> 
> Diff: https://reviews.apache.org/r/32932/diff/
> 
> 
> Testing
> -------
> 
> 5781 tests complete (21 seconds)
>   78 tests pending
> 
> 
> Thanks,
> 
> Di Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message