ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 32932: The stop service confirmation dialog should show a warning if some other services depends on the one to be stopped
Date Wed, 08 Apr 2015 18:33:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32932/#review79391
-----------------------------------------------------------

Ship it!



ambari-web/app/controllers/main/service/item.js
<https://reviews.apache.org/r/32932/#comment128692>

    Will this only happen when stopping a service as a whole? What is the behavior for stopping
an individual component?



ambari-web/app/messages.js
<https://reviews.apache.org/r/32932/#comment128690>

    Just use one message and label it as "service(s)"


- Alejandro Fernandez


On April 8, 2015, 6:05 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32932/
> -----------------------------------------------------------
> 
> (Updated April 8, 2015, 6:05 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-10333
>     https://issues.apache.org/jira/browse/AMBARI-10333
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The stop service confirmation dialog should show a warning if some other services depends
on the service to be stopped, so that the user is warned about the other services may not
function properly after the selected service is stopped. For example, stopping HDFS would
bring up a warning saying the HBase depends on HDFS. User then has the option to either Cancel
the operation or click Confirm Stop to continue.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/item.js 8f817d2 
>   ambari-web/app/messages.js 6feaf0b 
>   ambari-web/test/controllers/main/service/item_test.js 7d57570 
> 
> Diff: https://reviews.apache.org/r/32932/diff/
> 
> 
> Testing
> -------
> 
> 5780 tests complete (12 seconds)
>   78 tests pending
> 
> 
> Thanks,
> 
> Di Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message