ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jaimin Jetly" <jai...@hortonworks.com>
Subject Re: Review Request 32957: Update widgets.json for HBase and add for HDFS and YARN
Date Wed, 08 Apr 2015 16:30:15 GMT


> On April 8, 2015, 6:56 a.m., Yusaku Sako wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/widgets.json, line
9
> > <https://reviews.apache.org/r/32957/diff/1/?file=920421#file920421line9>
> >
> >     For this and other NodeManager metrics, shouldn't we just say NodeManager rather
than YARN?
> >     For example, "NodeManager Garbage Collection Time" rather than "YARN Garbage
Collection Time".

Personally I agree that "Datanode instead of HDFS and NodeManager instead of YARN" is more
accurate. But for all the heatmap I kept displayname same as we have right now hardcoded on
UI (HDFS instead of datanode and YARN instaead of NodeManager). So there is no change in the
look and feel of the heatmap page on upgrade from previous versions of ambari. I can do it
other way which is more precise


- Jaimin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32957/#review79318
-----------------------------------------------------------


On April 8, 2015, 2:35 a.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32957/
> -----------------------------------------------------------
> 
> (Updated April 8, 2015, 2:35 a.m.)
> 
> 
> Review request for Ambari, Sid Wagle and Yusaku Sako.
> 
> 
> Bugs: AMBARI-10393
>     https://issues.apache.org/jira/browse/AMBARI-10393
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This includes updating HBase widgets.json and adding HDFS and YARN widgets.json files.
These are default widget definitions which will be used to populate widget instances in ambari
database on respective service resource creation (This will done with a seperate ticket).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metrics.json 7bbf7be

>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/widgets.json a64a2c8

>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metrics.json 6fc808e

>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json PRE-CREATION

>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/widgets.json PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/32957/diff/
> 
> 
> Testing
> -------
> 
> Manually Teseted the patch on  cluster
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message