ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 32969: Add necessary mocks for unit tests to pass on any OS
Date Wed, 08 Apr 2015 13:26:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32969/#review79337
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On April 8, 2015, 1:24 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32969/
> -----------------------------------------------------------
> 
> (Updated April 8, 2015, 1:24 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-10398
>     https://issues.apache.org/jira/browse/AMBARI-10398
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Tests failed (on Mac):
> 
>   * FAIL: test_stop_suse (TestMonitorWebserverResource.TestMonitorWebserverResource)
>   * FAIL: test_setup_suse (TestMonitorWebserverResource.TestMonitorWebserverResource)
>     
>     
>     ======================================================================
>     FAIL: test_setup_suse (TestMonitorWebserverResource.TestMonitorWebserverResource)
>     ----------------------------------------------------------------------
>     Traceback (most recent call last):
>       File "/Users/smohanty/enlistments/asf-ambari/ambari-common/src/test/python/mock/mock.py",
line 1199, in patched
>         return func(*args, **keywargs)
>       File "/Users/smohanty/enlistments/asf-ambari/ambari-agent/src/test/python/resource_management/TestMonitorWebserverResource.py",
line 58, in test_setup_suse
>         self.assertEqual(str(defined_resources), expected_resources)
>     AssertionError: "[MonitorWebserver['start'], Execute['grep -E 'KeepAlive (On|Off)'
/etc/httpd/conf/httpd.conf && ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E sed -i 's/KeepAlive
Off/KeepAlive On/' /etc/httpd/conf/httpd.conf || echo 'KeepAlive On' | ambari-sudo.sh [RMF_ENV_PLACEHOLDER]
-H -E tee --append /etc/httpd/conf/httpd.conf > /dev/null'], Execute['('/etc/init.d/httpd',
'start')']]" != "[MonitorWebserver['start'], Execute['grep -E 'KeepAlive (On|Off)' /etc/apache2/httpd.conf
&& ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E sed -i 's/KeepAlive Off/KeepAlive On/'
/etc/apache2/httpd.conf || echo 'KeepAlive On' | ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E
tee --append /etc/apache2/httpd.conf > /dev/null'], Execute['('/etc/init.d/apache2', 'start')']]"
>     
>     ======================================================================
>     FAIL: test_stop_suse (TestMonitorWebserverResource.TestMonitorWebserverResource)
>     ----------------------------------------------------------------------
>     Traceback (most recent call last):
>       File "/Users/smohanty/enlistments/asf-ambari/ambari-common/src/test/python/mock/mock.py",
line 1199, in patched
>         return func(*args, **keywargs)
>       File "/Users/smohanty/enlistments/asf-ambari/ambari-agent/src/test/python/resource_management/TestMonitorWebserverResource.py",
line 80, in test_stop_suse
>         self.assertEqual(str(defined_resources), expected_resources)
>     AssertionError: "[MonitorWebserver['stop'], Execute['('/etc/init.d/httpd', 'stop')']]"
!= "[MonitorWebserver['stop'], Execute['('/etc/init.d/apache2', 'stop')']]"
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/test/python/resource_management/TestMonitorWebserverResource.py f149a3c

> 
> Diff: https://reviews.apache.org/r/32969/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message