ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrii Tkach" <atk...@hortonworks.com>
Subject Re: Review Request 32897: Create widget wizard: Implement metrics selection and expression formation on "Metrics and Expression" page
Date Tue, 07 Apr 2015 09:57:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32897/
-----------------------------------------------------------

(Updated Апрель 7, 2015, 9:57 д.п.)


Review request for Ambari and Jaimin Jetly.


Bugs: AMBARI-10373
    https://issues.apache.org/jira/browse/AMBARI-10373


Repository: ambari


Description
-------

Tasks that needs to be done as part of this ticket:
1. Create model for Metrics. Attributes to capture in the model is name, widget_id, service_name,
component_name, type, temporal, pointInTime and level. All of these are available from API
response
2. On transition from step-1 "Choose Type" to "Metrics & Expression" page, map Metrics
model from API response of following call


Diffs (updated)
-----

  ambari-web/app/assets/data/metrics/HBASE/definition.json PRE-CREATION 
  ambari-web/app/controllers/global/background_operations_controller.js bf2a65f 
  ambari-web/app/controllers/main/service/widgets/create/step1_controller.js 1e73ef1 
  ambari-web/app/controllers/main/service/widgets/create/step2_controller.js 62d935a 
  ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js d63eaa3 
  ambari-web/app/messages.js 73691db 
  ambari-web/app/styles/enhanced_service_dashboard.less e2acbe2 
  ambari-web/app/templates/main/service/widgets/create/expression.hbs PRE-CREATION 
  ambari-web/app/templates/main/service/widgets/create/step1.hbs 0f37f10 
  ambari-web/app/templates/main/service/widgets/create/step2.hbs 8ab4c03 
  ambari-web/app/templates/main/service/widgets/create/step2_add_metric.hbs PRE-CREATION 
  ambari-web/app/templates/main/service/widgets/create/step3.hbs 95753d9 
  ambari-web/app/templates/main/service/widgets/create/wizard.hbs 0971645 
  ambari-web/app/utils/ajax/ajax.js 4fe1171 
  ambari-web/app/views.js 48d86d7 
  ambari-web/app/views/main/service/widgets/create/expression_view.js PRE-CREATION 
  ambari-web/app/views/main/service/widgets/create/step2_view.js 4bbcd44 

Diff: https://reviews.apache.org/r/32897/diff/


Testing
-------

5788 tests complete (11 seconds)
  78 tests pending


Thanks,

Andrii Tkach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message