ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 32804: Falcon View to use doAs impersonation for user.name in Ambari Views
Date Tue, 07 Apr 2015 00:43:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32804/#review79095
-----------------------------------------------------------


Sorry I took so long to review this.  I missed it over the weekend.

The main thing here is that HttpImpersonator has been deprecated.  We shouldn't be making
any changes to it.  The view URLStreamProvider readAs should provide the same functionality.
 If we need to make changes they should be done there.

The other issue is that the view framework can not have knowledge of specific views.  Can
you explain why these changes only apply to Falcon?  Is it something that can be made view
configurable so that we can turn it on for the Falcon view without hardcoding it in the framework?


ambari-server/src/test/java/org/apache/ambari/server/view/HttpImpersonatorImplTest.java
<https://reviews.apache.org/r/32804/#comment128195>

    How come I don't see a change for FALCON_AMBARI_VIEW in HttpImpersonator?
    
    Also, we can't do this.  The view framework can't have knowledge of specific views.  Why
do these changes only apply to Falcon?



ambari-views/src/main/java/org/apache/ambari/view/HttpImpersonator.java
<https://reviews.apache.org/r/32804/#comment128194>

    The impersonator is deprecated.  We shouldn't be making changes to it.  We should be using
the view URLStreamProvider instead.  Can we make the changes there?


- Tom Beerbower


On April 3, 2015, 10:55 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32804/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 10:55 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Tom Beerbower, Venkat Ranganathan, and Yusaku
Sako.
> 
> 
> Bugs: AMBARI-10341
>     https://issues.apache.org/jira/browse/AMBARI-10341
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Falcon View needs to use the HttpImpersonator interface in Ambari Views so it can proxy
using the header user.name
> 
> HttpImpersonatorImpl.java should only allow this if the request headers indicate it is
for the Falcon View.
> 
> 
> Diffs
> -----
> 
>   ambari-server/pom.xml 896a202 
>   ambari-server/src/main/java/org/apache/ambari/server/view/HttpImpersonatorImpl.java
fe4e180 
>   ambari-server/src/test/java/org/apache/ambari/server/view/HttpImpersonatorImplTest.java
935b488 
>   ambari-views/pom.xml 8fcb5ae 
>   ambari-views/src/main/java/org/apache/ambari/view/HttpImpersonator.java 02ce101 
>   ambari-views/src/main/java/org/apache/ambari/view/ImpersonatorResponse.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/32804/diff/
> 
> 
> Testing
> -------
> 
> Ran local unit tests in HttpImpersonatorImplTest.java passed.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message