ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Kozlov" <ikoz...@hortonworks.com>
Subject Re: Review Request 32803: Create an API endpoint for widget_layouts
Date Mon, 06 Apr 2015 18:02:05 GMT


> On Квітень 6, 2015, 5:45 після полудня, Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/resources/WidgetResourceDefinition.java,
line 45
> > <https://reviews.apache.org/r/32803/diff/2/?file=916621#file916621line45>
> >
> >     Since all widgets are cluster widgets, we should have href here as well, right?

this is done automatically by BaseHrefPostProcessor


> On Квітень 6, 2015, 5:45 після полудня, Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetEntity.java,
line 36
> > <https://reviews.apache.org/r/32803/diff/2/?file=916633#file916633line36>
> >
> >     We should change table name to reflect chnages we made to entity and call it
widget.

plan to change table name when creating widgets endpoint


> On Квітень 6, 2015, 5:45 після полудня, Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutEntity.java,
line 80
> > <https://reviews.apache.org/r/32803/diff/2/?file=916634#file916634line80>
> >
> >     What does orpahn mean here? WidgetLayout -> Widget is not a parent child
relationship.

there is a relationship table widget_layout_user_widget and we should delete all relations
when widget_layout is deleted. we do not use many-to-many here as we need ordering for this
relations and it is stored in widget_layout_user_widget.


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32803/#review78945
-----------------------------------------------------------


On Квітень 6, 2015, 5:34 після полудня, Ivan Kozlov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32803/
> -----------------------------------------------------------
> 
> (Updated Квітень 6, 2015, 5:34 після полудня)
> 
> 
> Review request for Ambari, Jaimin Jetly and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Request for getting order of the widgets specific to a user
> /api/v1/users/admin/widget_layouts/default_hdfs_layout
> /api/v1/users/admin/widget_layouts?section_name=HDFS_SUMMARY
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
7183fa7 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/WidgetLayoutResourceDefinition.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/WidgetResourceDefinition.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
a794693 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/WidgetLayoutService.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java
5e6df6b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/WidgetResponse.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
113087c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetLayoutResourceProvider.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 6e5db3a

>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserWidgetDAO.java 834da26

>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/WidgetDAO.java PRE-CREATION

>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/WidgetLayoutDAO.java 55e7513

>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserWidgetEntity.java
ec84181 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetEntity.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutEntity.java
dfce4f4 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutUserWidgetEntity.java
5de9f89 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java
d1a0bbe 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3bfe959 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 807306f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f728bdf 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 034639d 
>   ambari-server/src/main/resources/META-INF/persistence.xml 3146aff 
>   ambari-server/src/main/resources/properties.json 300d77e 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParserTest.java
f89b1b3 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/WidgetLayoutResourceProviderTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserWidgetDAOTest.java
f86dde8 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/WidgetDAOTest.java PRE-CREATION

>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/WidgetLayoutDAOTest.java
3d83399 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java
513e98a 
> 
> Diff: https://reviews.apache.org/r/32803/diff/
> 
> 
> Testing
> -------
> 
> Tests run: 2819, Failures: 0, Errors: 0, Skipped: 16
> 
> 
> Thanks,
> 
> Ivan Kozlov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message