ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David McWhorter" <da...@mcwhorter.io>
Subject Re: Review Request 32791: Knox gateway fails to restart on Ubuntu 12.04 after system restart because /var/run/knox is deleted
Date Fri, 03 Apr 2015 15:43:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32791/#review78784
-----------------------------------------------------------

Ship it!


Looks good.  I've tested it by applying the patch to branch-2.0.0, building ambari-server,
installing on a new Ubuntu 12.04 test cloud, bringing the machine hosting the knox gateway
down and then back up, and verifying that Knox gateway restarts without error.

- David McWhorter


On April 2, 2015, 9:47 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32791/
> -----------------------------------------------------------
> 
> (Updated April 2, 2015, 9:47 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-10317
>     https://issues.apache.org/jira/browse/AMBARI-10317
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When an Ubuntu 12 host is restarted, its /var/run/knox folder is deleted. There's a bug
in knox.py in which it doesn't check that all of the directories it needs are created.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py
108ebb2 
>   ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py b1d9888 
> 
> Diff: https://reviews.apache.org/r/32791/diff/
> 
> 
> Testing
> -------
> 
> Spun up a 1 node cluster with Ubuntu, installed Knox and then stoped it, restarted the
machine, and Knox failed to start.
> After deploying the patch, was able to start Knox.
> 
> Local python unit tests passed,
> ----------------------------------------------------------------------
> Total run:654
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message