ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 32731: AMBARI-10280 Need to check if rpcbind or portmap is started before starting NFS Gateway
Date Wed, 01 Apr 2015 21:22:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32731/#review78593
-----------------------------------------------------------

Ship it!


Need unit test results.


ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py
<https://reviews.apache.org/r/32731/#comment127486>

    If this is not needed, then remove it.



ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py
<https://reviews.apache.org/r/32731/#comment127487>

    Can you add the same comments about the bug in Linux here, since this is where I dont
want a dev to inadvertently change this back to "hdfs".


- Alejandro Fernandez


On April 1, 2015, 9:10 p.m., Brandon Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32731/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 9:10 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-10280
>     https://issues.apache.org/jira/browse/AMBARI-10280
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMBARI-10280 Need to check if rpcbind or portmap is started before starting NFS Gateway
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py
e908ecf 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py
58773bd 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py
c7c5325 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
0b9af6b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py 4fdf740 
> 
> Diff: https://reviews.apache.org/r/32731/diff/
> 
> 
> Testing
> -------
> 
> Manually tested it on VM.
> The python unit test test_nfsgateway.py failed because now NFS is started by root not
hdfs anymore.
> 
> 
> Thanks,
> 
> Brandon Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message