Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4795C10119 for ; Mon, 2 Mar 2015 19:08:06 +0000 (UTC) Received: (qmail 6550 invoked by uid 500); 2 Mar 2015 19:08:05 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 6453 invoked by uid 500); 2 Mar 2015 19:08:05 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 6186 invoked by uid 99); 2 Mar 2015 19:08:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Mar 2015 19:08:05 +0000 Date: Mon, 2 Mar 2015 19:08:05 +0000 (UTC) From: "Alejandro Fernandez (JIRA)" To: dev@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMBARI-9805) RU - Bug fixes for Host Version transition and Finalize MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMBARI-9805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343590#comment-14343590 ] Alejandro Fernandez commented on AMBARI-9805: --------------------------------------------- Pushed to branch-2.0.0 in commit f5c7ac418ee5566dbee7dc2f06365b80a46fa2c0 > RU - Bug fixes for Host Version transition and Finalize > ------------------------------------------------------- > > Key: AMBARI-9805 > URL: https://issues.apache.org/jira/browse/AMBARI-9805 > Project: Ambari > Issue Type: Bug > Components: ambari-server > Affects Versions: 2.0.0 > Reporter: Alejandro Fernandez > Assignee: Alejandro Fernandez > Labels: rolling_upgrade > Fix For: 2.0.0 > > Attachments: AMBARI-9805.patch > > > 1. There is a bug in ServiceComponentHostSummary.java since its constructor should not be comparing against the string UKNOWN, but rather rely on ComponentInfo to determine which components need to advertise a version. Also, the function haveAllComponentsFinishedAdvertisingVersion should instead compare the size of all components that can advertise a version, and the subset of those that have done so already. > 2. ClusterImpl.java has a bug in transitionHostVersionState() when setting the state to UPGRADING if the Host has exactly one Component with a version. > 3. FinalizeUpgradeAction.java has redundant code now that AMBARI-9755 is in because the call to transitionClusterVersion() will also take care of transitioning HostVersions from INSTALLED->CURRENT for hosts that only have components that do not advertise a version. > It is of the utmost importance to test these changes in the following scenarios: > Host added during cluster install > Host added after cluster install > Host added after bits are distributed > A Host may be added with either 0 services, only services that do not advertise a version, or at least one service that advertises a version. -- This message was sent by Atlassian JIRA (v6.3.4#6332)