Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============6228534252044039236=="
MIME-Version: 1.0
Subject: Re: Review Request 32312: Widgets: Add schema tables for PostgreSQL,
 MySQL and Oracle
From: "Ivan Kozlov" <ikozlov@hortonworks.com>
To: "Sid Wagle" <swagle@hortonworks.com>,
 "Jaimin Jetly" <jaimin@hortonworks.com>
Cc: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Ivan Kozlov" <ikozlov@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Wed, 25 Mar 2015 17:13:00 -0000
Message-ID: <20150325171300.1504.22044@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Ivan Kozlov" <noreply@reviews.apache.org>
References: <20150324213709.1504.47462@reviews.apache.org>
In-Reply-To: <20150324213709.1504.47462@reviews.apache.org>
Reply-To: "Ivan Kozlov" <ikozlov@hortonworks.com>

--===============6228534252044039236==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32312/
-----------------------------------------------------------

(Updated Березень 25, 2015, 5:12 після полудня)


Review request for Ambari, Jaimin Jetly and Sid Wagle.


Repository: ambari


Description
-------

Apart from adding new widget related table definitions in the DDL script for all the three database types, also update the upgrade catalog for Amabri-2.1.0 to create these tables on ambari upgrade.
Tasks:
Create WidgetEntity and WidgetLayoutEntity.
Add relationship from both entities to cluster. This will not be used to load widgets but only to find what StackVersion to use for lookup of stack widgets when requesting WidgetInfo with layouts.
Create corresponding DAO objects with unit tests
Create findById and findBySectionName and findByCluster
Note: There is no direct relationship between the two.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserWidgetDAO.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/WidgetLayoutDAO.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserWidgetEntity.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutEntity.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutUserWidgetEntity.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutUserWidgetEntityPK.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 5968b2f 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java PRE-CREATION 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9ff62df 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 7d62aee 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 78a263f 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql a06f1d2 
  ambari-server/src/main/resources/META-INF/persistence.xml 8c0d85f 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserWidgetDAOTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/WidgetLayoutDAOTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java PRE-CREATION 

Diff: https://reviews.apache.org/r/32312/diff/


Testing
-------


Thanks,

Ivan Kozlov


--===============6228534252044039236==--