Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BAE5317513 for ; Sat, 14 Mar 2015 03:17:08 +0000 (UTC) Received: (qmail 85504 invoked by uid 500); 14 Mar 2015 03:17:08 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 85457 invoked by uid 500); 14 Mar 2015 03:17:08 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 85440 invoked by uid 99); 14 Mar 2015 03:17:08 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Mar 2015 03:17:08 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DE10A1D417A; Sat, 14 Mar 2015 03:17:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7900183761055756034==" MIME-Version: 1.0 Subject: Re: Review Request 32065: RU - AMS service check may fail, need to exclude AMS from Service Check Group in Upgrade Pack From: "Sid Wagle" To: "Nate Cole" , "Sid Wagle" , "Jonathan Hurley" Cc: "Alejandro Fernandez" , "Ambari" Date: Sat, 14 Mar 2015 03:17:07 -0000 Message-ID: <20150314031707.1507.22846@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sid Wagle" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/32065/ X-Sender: "Sid Wagle" References: <20150314021216.1507.35083@reviews.apache.org> In-Reply-To: <20150314021216.1507.35083@reviews.apache.org> Reply-To: "Sid Wagle" X-ReviewRequest-Repository: ambari --===============7900183761055756034== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32065/#review76479 ----------------------------------------------------------- Ship it! Ship It! - Sid Wagle On March 14, 2015, 2:12 a.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32065/ > ----------------------------------------------------------- > > (Updated March 14, 2015, 2:12 a.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, and Sid Wagle. > > > Bugs: AMBARI-10070 > https://issues.apache.org/jira/browse/AMBARI-10070 > > > Repository: ambari > > > Description > ------- > > During a rolling upgrade, the AMS service check is failing. > Since AMS is not part of the upgrade pack, Ambari RU should be robust enough to proceed without it in case it does fail. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java 4eedde2 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml b3b351b > ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java 95b7581 > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 96c01d5 > ambari-server/src/test/resources/stacks/HDP/2.1.1/services/AMBARI_METRICS/metainfo.xml PRE-CREATION > ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_checks.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/32065/diff/ > > > Testing > ------- > > Unit tests passed, still need to test during a Rolling Upgrade. > > [INFO] ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [5.137s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.029s] > [INFO] Ambari Web ........................................ SUCCESS [37.414s] > [INFO] Ambari Views ...................................... SUCCESS [2.081s] > [INFO] Ambari Admin View ................................. SUCCESS [9.238s] > [INFO] Ambari Metrics Common ............................. SUCCESS [1.244s] > [INFO] Ambari Server ..................................... SUCCESS [31:47.183s] > [INFO] Ambari Agent ...................................... SKIPPED > [INFO] Ambari Client ..................................... SKIPPED > [INFO] Ambari Python Client .............................. SKIPPED > [INFO] Ambari Groovy Client .............................. SKIPPED > [INFO] Ambari Shell ...................................... SKIPPED > [INFO] Ambari Python Shell ............................... SKIPPED > [INFO] Ambari Groovy Shell ............................... SKIPPED > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 32:42.923s > [INFO] Finished at: Fri Mar 13 18:44:10 PDT 2015 > [INFO] Final Memory: 51M/444M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Alejandro Fernandez > > --===============7900183761055756034==--