Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0BBC517468 for ; Thu, 5 Mar 2015 13:57:57 +0000 (UTC) Received: (qmail 26612 invoked by uid 500); 5 Mar 2015 13:57:56 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 26581 invoked by uid 500); 5 Mar 2015 13:57:56 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 26558 invoked by uid 99); 5 Mar 2015 13:57:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Mar 2015 13:57:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7A0211C0272; Thu, 5 Mar 2015 13:57:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1520358535963090016==" MIME-Version: 1.0 Subject: Re: Review Request 31752: ambari-sudo.sh needs full path, install fails if JDK is not installed From: "Andrew Onischuk" To: "Andrew Onischuk" , "Nate Cole" , "Sid Wagle" , "Jonathan Hurley" Cc: "Ambari" , "Alejandro Fernandez" Date: Thu, 05 Mar 2015 13:57:55 -0000 Message-ID: <20150305135755.5896.91863@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Andrew Onischuk" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/31752/ X-Sender: "Andrew Onischuk" References: <20150305131549.12262.20777@reviews.apache.org> In-Reply-To: <20150305131549.12262.20777@reviews.apache.org> Reply-To: "Andrew Onischuk" X-ReviewRequest-Repository: ambari --===============1520358535963090016== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On March 5, 2015, 1:15 p.m., Nate Cole wrote: > > Seems like we should be abstracting somehow - maybe with an ExecuteSudo or something that takes the same exact arguments as Execute, but does all this sudo voodoo. > > Jonathan Hurley wrote: > Agreed; why is the separate script necessary? I even thought that the existing Execute resource took a `sudo=true` parameter. Guys we have Execute with sudo=True argument. This thing on lower level below this Execute. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31752/#review75325 ----------------------------------------------------------- On March 5, 2015, 12:59 a.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31752/ > ----------------------------------------------------------- > > (Updated March 5, 2015, 12:59 a.m.) > > > Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and Sid Wagle. > > > Bugs: AMBARI-9938 > https://issues.apache.org/jira/browse/AMBARI-9938 > > > Repository: ambari > > > Description > ------- > > When HDP is installed on a host without JDK, the before-install hook will attempt to install JDK if it is not present. However, this fails because ambari-sudo.sh needs the fully qualified path to the script. > > ``` > Execution of 'mkdir -p /var/lib/ambari-agent/data/tmp/jdk && cd /var/lib/ambari-agent/data/tmp/jdk && tar -xf /var/lib/ambari-agent/data/tmp/AMBARI-artifacts//jdk-7u67-linux-x64.tar.gz && ambari-sudo.sh cp -r /var/lib/ambari-agent/data/tmp/jdk/* /usr/jdk64' returned 2. > [3/4/15, 12:58:13 PM] Alejandro Fernandez: tar: Unexpected EOF in archive > ``` > > > Diffs > ----- > > ambari-common/src/main/python/ambari_commons/constants.py b823b31 > ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py b6f4821 > ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 396b9d2 > ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py 7d0afc7 > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 36c942e > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 8a79701 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 54ca083 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 21cefae > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 1e4142f > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py e24ff8d > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8aa4871 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 9153a84 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 5230196 > ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 8d388ab > ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py e038ddf > ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 990eac8 > ambari-server/src/test/python/stacks/2.1/STORM/test_storm_drpc_server.py d5afb42 > ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 3ef45ad > ambari-server/src/test/python/stacks/2.1/STORM/test_storm_rest_api_service.py 64a4662 > ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor.py 26089fb > ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py 549c5fc > ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py d23114a > ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py b1d9888 > > Diff: https://reviews.apache.org/r/31752/diff/ > > > Testing > ------- > > Waiting for unit test results. > > Local tests passed, > ---------------------------------------------------------------------- > Total run:609 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > > --===============1520358535963090016==--