ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-10184) Admin View: property validation needs to show for instance invalid
Date Mon, 23 Mar 2015 20:16:53 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-10184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376554#comment-14376554
] 

Hadoop QA commented on AMBARI-10184:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12706586/AMBARI-10184.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-admin.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/2116//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/2116//console

This message is automatically generated.

> Admin View: property validation needs to show for instance invalid
> ------------------------------------------------------------------
>
>                 Key: AMBARI-10184
>                 URL: https://issues.apache.org/jira/browse/AMBARI-10184
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-web
>    Affects Versions: 2.0.0
>            Reporter: Antonenko Alexander
>            Assignee: Antonenko Alexander
>             Fix For: 2.1.0
>
>         Attachments: AMBARI-10184.patch
>
>
> The Admin View UI is correctly handling the cases of property validation and showing
the errors next to view configuration property.
> But in the case of instance validation failing, the API is returning the information
but that is not shown in the UI. The UI must also show that info as well.
> There is a part of the response that in the case of instance validation failure, it returns
valid = false not associated with a property. In the below response, it's telling me the second
value must be greater than the first.
> {code}
> {
>   "status": 500,
>   "message": "{\"propertyResults\":{\"freeform\":{\"valid\":true,\"detail\":\"OK\"},\"integer\":{\"valid\":true,\"detail\":\"OK\"},\"first.value\":{\"valid\":true,\"detail\":\"OK\"},\"second.value\":{\"valid\":true,\"detail\":\"OK\"},\"url\":{\"valid\":true,\"detail\":\"OK\"}},\"valid\":false,\"detail\":\"Second
value must be greater or equal to first\"}"
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message