ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jaimin Jetly" <jai...@hortonworks.com>
Subject Re: Review Request 32706: Create widget wizard: Implement the initial layout of the wizard
Date Tue, 31 Mar 2015 23:34:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32706/
-----------------------------------------------------------

(Updated March 31, 2015, 11:34 p.m.)


Review request for Ambari, Xi Wang and Yusaku Sako.


Changes
-------

Added launching of the "create widget" wizard from widget action dropdowm


Bugs: AMBARI-10304
    https://issues.apache.org/jira/browse/AMBARI-10304


Repository: ambari


Description
-------

As a part of this ticket create the wizard flow: launching of the wizard, navigation of the
wizard, handling browser refreshes by storing required data on seperate pages in browser local
db


Diffs (updated)
-----

  ambari-web/app/controllers.js 56b144d 
  ambari-web/app/controllers/main/service/info/summary.js 1eec9d1 
  ambari-web/app/controllers/main/service/widgets/create/step1_controller.js PRE-CREATION

  ambari-web/app/controllers/main/service/widgets/create/step2_controller.js PRE-CREATION

  ambari-web/app/controllers/main/service/widgets/create/step3_controller.js PRE-CREATION

  ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js PRE-CREATION

  ambari-web/app/data/service_graph_config.js 36da518 
  ambari-web/app/messages.js 86093fc 
  ambari-web/app/models/widget.js e00cd05 
  ambari-web/app/routes/add_widget.js PRE-CREATION 
  ambari-web/app/routes/main.js 739f9c9 
  ambari-web/app/templates/main/service/info/summary.hbs 92f7cbd 
  ambari-web/app/templates/main/service/widgets/create/step1.hbs PRE-CREATION 
  ambari-web/app/templates/main/service/widgets/create/step2.hbs PRE-CREATION 
  ambari-web/app/templates/main/service/widgets/create/step3.hbs PRE-CREATION 
  ambari-web/app/templates/main/service/widgets/create/wizard.hbs PRE-CREATION 
  ambari-web/app/utils/db.js e5f9bb7 
  ambari-web/app/views.js 6a29279 
  ambari-web/app/views/main/service/info/summary.js f4e123d 
  ambari-web/app/views/main/service/widgets/create/step1_view.js PRE-CREATION 
  ambari-web/app/views/main/service/widgets/create/step2_view.js PRE-CREATION 
  ambari-web/app/views/main/service/widgets/create/step3_view.js PRE-CREATION 
  ambari-web/app/views/main/service/widgets/create/wizard_view.js PRE-CREATION 

Diff: https://reviews.apache.org/r/32706/diff/


Testing
-------

Tested on the ambari-web brunch server.
ambari-web unit test result with the patch:

  5752 tests complete (10 seconds)
  68 tests pending


Thanks,

Jaimin Jetly


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message