ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 32644: Storm Shows An Alert for REST_API Component After Stack Upgrade
Date Mon, 30 Mar 2015 23:07:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32644/#review78278
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On March 30, 2015, 5:17 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32644/
> -----------------------------------------------------------
> 
> (Updated March 30, 2015, 5:17 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Tom Beerbower.
> 
> 
> Bugs: AMBARI-10285
>     https://issues.apache.org/jira/browse/AMBARI-10285
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - Upgraded cluster with storm.
> - Noticed a CRITICAL alert named "Storm REST API". But there are no REST API components
on stack 2.2. The alert is linking to host with Storm UI Server.
> 
> The underlying problem here is that, indeed, Storm REST API was removed on HDP 2.2. However,
Ambari doesn't remove the relationships in the database; it just modifies the in-memory stack
definitions.
> 
> As a result, the alerts framework still thinks there's a REST_API component installed
on a host. In order to preserve the historical entires for that component, alerts will determine
at startup the definitions which may no longer be valid and will disable them.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
143022e 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java
659fb21 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java
cd06e23 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
96e7ff2 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java
acf25d2 
> 
> Diff: https://reviews.apache.org/r/32644/diff/
> 
> 
> Testing
> -------
> 
> Manual verification that the invalid alert definition was removed. New tests written
to cover DAO and AmbariMetaInfo changes.
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message