ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vitalyi Brodetskyi" <vbrodets...@hortonworks.com>
Subject Review Request 32620: Running ambari-server setup -s should not do anything after already setup
Date Mon, 30 Mar 2015 12:52:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32620/
-----------------------------------------------------------

Review request for Ambari and Andrew Onischuk.


Bugs: AMBARI-10270
    https://issues.apache.org/jira/browse/AMBARI-10270


Repository: ambari


Description
-------

Users run "ambari-server setup" for their first-time setup of ambari to select JDK, service
account, database, etc. They can also run "-s" to just accept the defaults and run w/o interaction.
After first time setup, if the user accidentally calls setup with "-s" they lose all their
setup (i.e. goes back to default). This can be very bad.
After firsttime setup (whether run with or without -s), the -s option should basically do
nothing to avoid users accidentally hurting their ambari-server setup.


Diffs
-----

  ambari-server/src/main/python/ambari_server/serverSetup.py 9e15c43 

Diff: https://reviews.apache.org/r/32620/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message