ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Review Request 32572: Refactor unitests for upgradeHelper.py
Date Fri, 27 Mar 2015 14:24:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32572/
-----------------------------------------------------------

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-10238
    https://issues.apache.org/jira/browse/AMBARI-10238


Repository: ambari


Description
-------

upgradeHelper.py should be covered by unitests. Initial unittest module
already created "ambari/ambari-server/src/test/python/TestUpgradeHelper.py"
(will come with patch).

This task is a re-factor task of previously existed module
TestUpgradeScript_HDP2.py, but as upgradeHelper.py was re-factored, unit tests
should be re-factored too.


Diffs
-----

  ambari-server/src/main/python/upgradeHelper.py 11292e9 
  ambari-server/src/test/python/TestUpgradeHelper.py 2f47620 

Diff: https://reviews.apache.org/r/32572/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message