ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Kozlov" <ikoz...@hortonworks.com>
Subject Re: Review Request 32312: Widgets: Add schema tables for PostgreSQL, MySQL and Oracle
Date Thu, 26 Mar 2015 15:18:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32312/
-----------------------------------------------------------

(Updated Березень 26, 2015, 3:18 після полудня)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sid Wagle.


Bugs: AMBARI-10212
    https://issues.apache.org/jira/browse/AMBARI-10212


Repository: ambari


Description
-------

Apart from adding new widget related table definitions in the DDL script for all the three
database types, also update the upgrade catalog for Amabri-2.1.0 to create these tables on
ambari upgrade.
Tasks:
Create WidgetEntity and WidgetLayoutEntity.
Add relationship from both entities to cluster. This will not be used to load widgets but
only to find what StackVersion to use for lookup of stack widgets when requesting WidgetInfo
with layouts.
Create corresponding DAO objects with unit tests
Create findById and findBySectionName and findByCluster
Note: There is no direct relationship between the two.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserWidgetDAO.java PRE-CREATION

  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/WidgetLayoutDAO.java PRE-CREATION

  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserWidgetEntity.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutEntity.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutUserWidgetEntity.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutUserWidgetEntityPK.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 5968b2f

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java PRE-CREATION

  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9ff62df 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 7d62aee 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 78a263f 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql a06f1d2 
  ambari-server/src/main/resources/META-INF/persistence.xml 8c0d85f 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserWidgetDAOTest.java PRE-CREATION

  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/WidgetLayoutDAOTest.java PRE-CREATION

  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/32312/diff/


Testing
-------

unittests

Tests run: 2797, Failures: 0, Errors: 0, Skipped: 15


Thanks,

Ivan Kozlov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message