ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 32512: Alert Notifications Are Not Received Without Restarting Ambari Server
Date Thu, 26 Mar 2015 13:30:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32512/
-----------------------------------------------------------

(Updated March 26, 2015, 9:30 a.m.)


Review request for Ambari, Nate Cole and Tom Beerbower.


Bugs: AMBARI-9823
    https://issues.apache.org/jira/browse/AMBARI-9823


Repository: ambari


Description
-------

When creating an alert target and associating it with a group, retrieving the group by alert
definition gets back a group without any targets. The database is correct and restarting Ambari
fixes the problem.

The entities are correctly setup in a bi-directional association. It seems as though without
the refresh cascade, there are cases where a refreshed entity will have stale child entities.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java
7d2c6c7 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java a267043


Diff: https://reviews.apache.org/r/32512/diff/


Testing (updated)
-------

Manual verification of the fix by:
- Starting Ambari with no targets
- Creating a new target and adding it to a group
- Triggering an alert
- Verifying the target received the alert
- 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 36:37 min
[INFO] Finished at: 2015-03-26T09:18:42-04:00
[INFO] Final Memory: 29M/428M
[INFO] ------------------------------------------------------------------------


Thanks,

Jonathan Hurley


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message