ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sid Wagle" <swa...@hortonworks.com>
Subject Re: Review Request 32312: Widgets: Add schema tables for PostgreSQL, MySQL and Oracle
Date Tue, 24 Mar 2015 21:44:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32312/#review77658
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserWidgetEntity.java
<https://reviews.apache.org/r/32312/#comment125810>

    What is the need for DISTINCT cluase ?



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java
<https://reviews.apache.org/r/32312/#comment125820>

    Why don't you use: org.apache.ambari.server.orm.DBAccessor#addFKConstraint(java.lang.String,
java.lang.String, java.lang.String, java.lang.String, java.lang.String, boolean, boolean)


- Sid Wagle


On March 24, 2015, 9:37 p.m., Ivan Kozlov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32312/
> -----------------------------------------------------------
> 
> (Updated March 24, 2015, 9:37 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Apart from adding new widget related table definitions in the DDL script for all the
three database types, also update the upgrade catalog for Amabri-2.1.0 to create these tables
on ambari upgrade.
> Tasks:
> Create WidgetEntity and WidgetLayoutEntity.
> Add relationship from both entities to cluster. This will not be used to load widgets
but only to find what StackVersion to use for lookup of stack widgets when requesting WidgetInfo
with layouts.
> Create corresponding DAO objects with unit tests
> Create findById and findBySectionName and findByCluster
> Note: There is no direct relationship between the two.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserWidgetDAO.java PRE-CREATION

>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/WidgetLayoutDAO.java PRE-CREATION

>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserWidgetEntity.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutEntity.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutUserWidgetEntity.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutUserWidgetEntityPK.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
5968b2f 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java
PRE-CREATION 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9ff62df 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 7d62aee 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 78a263f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql a06f1d2 
>   ambari-server/src/main/resources/META-INF/persistence.xml 8c0d85f 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserWidgetDAOTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/WidgetLayoutDAOTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32312/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Kozlov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message