ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andriy Babiichuk" <ababiic...@hortonworks.com>
Subject Re: Review Request 32436: YARN configs should show slider-widgets when configured in theme
Date Tue, 24 Mar 2015 13:02:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32436/#review77555
-----------------------------------------------------------

Ship it!


Ship It!

- Andriy Babiichuk


On Март 24, 2015, 1:02 п.п., Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32436/
> -----------------------------------------------------------
> 
> (Updated Март 24, 2015, 1:02 п.п.)
> 
> 
> Review request for Ambari, Andriy Babiichuk and Andrii Tkach.
> 
> 
> Bugs: ambari-10191
>     https://issues.apache.org/jira/browse/ambari-10191
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> YARN theme has slider widgets being used for various configs. The new configs UI should
make use of this information to show those configs as sliders.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/info/configs.js 0314afc 
>   ambari-web/app/styles/widgets.less 9746547 
>   ambari-web/app/templates/common/configs/service_config_layout_tab.hbs 9f3fb8e 
>   ambari-web/app/templates/common/configs/widgets/slider_config_widget.hbs 960bc72 
>   ambari-web/app/views/common/configs/service_config_layout_tab_view.js 2fa35b6 
>   ambari-web/app/views/common/configs/widgets/slider_config_widget_view.js 05306f5 
>   ambari-web/test/controllers/main/service/info/config_test.js a6785ee 
>   ambari-web/test/views/common/configs/widgets/slider_config_widget_view_test.js f34fb8f

> 
> Diff: https://reviews.apache.org/r/32436/diff/
> 
> 
> Testing
> -------
> 
> 5654 tests complete (11 seconds)
>   68 tests pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message