ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 32413: RU: Adding new host fails after finalized upgrade
Date Mon, 23 Mar 2015 20:54:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32413/#review77464
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On March 23, 2015, 8:20 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32413/
> -----------------------------------------------------------
> 
> (Updated March 23, 2015, 8:20 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-10189
>     https://issues.apache.org/jira/browse/AMBARI-10189
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> After finalizing, when adding a new host, the stack-defined repo base_url is used.  This
is incorrect, as the cluster current should be used instead.
> 
> The fix for this issue could be done by either:
> 1. Fix finalize to set the stack version.
> 2. Fix the repo info code to pull from cluster current.
> 
> #1 is quicker and least impact/easier to test.  The proper fix is #2 but requires more
careful thought and more time than is allotted.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
01bd9c7 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
c107d89 
> 
> Diff: https://reviews.apache.org/r/32413/diff/
> 
> 
> Testing
> -------
> 
> Manual + new unit test.
> 
> Automated results pending
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message