ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexandr Antonenko" <hiv...@gmail.com>
Subject Re: Review Request 32308: Creating "false" local user
Date Fri, 20 Mar 2015 18:30:27 GMT


> On March 20, 2015, 5:30 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml,
line 37
> > <https://reviews.apache.org/r/32308/diff/1/?file=901422#file901422line37>
> >
> >     We should avoid introducing a new propertyType if possible. 
> >     
> >     As of know there is just one property that needs to be tweaked. We can have
that logic hard-coded in the UI.
> >     
> >     If there are more occurrences of properties that needs to fall in USER section
and actual user should not be created on host machines then introducing a  new propertyType
is unavoidable but for now we can defer it
> 
> Jaimin Jetly wrote:
>     Anyways the fix should resolve the issue. We can ship it

Hardcoding one of configs on UI can be, not so straightforward task, as it may look like.
Currently config loading/merging/saving has a lot of hardcode/dependencies. Because property
"ignore_groupsusers_create" will have property_type=undefined, number of places where we will
have to add changes can grow up. So we will have to very carefully double check that hardcode
on UI side.


For future purpose, can you please explain why we should avoid that ?


- Alexandr


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32308/#review77241
-----------------------------------------------------------


On March 20, 2015, 3:42 p.m., Alexandr Antonenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32308/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 3:42 p.m.)
> 
> 
> Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-10157
>     https://issues.apache.org/jira/browse/AMBARI-10157
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Looks like a user *false:x:506:503::/home/false:/bin/bash* is getting created by Ambari.
Does not seems tied to any specific combo of Stack or Services, is happening regardless of
combo.
> 
> zookeeper:x:502:503::/home/zookeeper:/bin/bash
> ams:x:503:503::/home/ams:/bin/bash
> ambari-qa:x:1001:503::/home/ambari-qa:/bin/bash
> tez:x:505:503::/home/tez:/bin/bash
> false:x:506:503::/home/false:/bin/bash
> hdfs:x:507:503::/home/hdfs:/bin/bash
> yarn:x:508:503::/home/yarn:/bin/bash
> mapred:x:509:503::/home/mapred:/bin/bash
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java e26b48f

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 1bfc1ee

>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/configuration/cluster-env.xml f014f8d

>   ambari-web/app/utils/config.js ed34232 
> 
> Diff: https://reviews.apache.org/r/32308/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexandr Antonenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message