ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 32312: Widgets: Add schema tables for PostgreSQL, MySQL and Oracle
Date Fri, 20 Mar 2015 17:57:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32312/#review77246
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserWidgetDAO.java
<https://reviews.apache.org/r/32312/#comment125114>

    Is that going to be a csv column, and hence the "%" wildcard search?



ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserWidgetEntity.java
<https://reviews.apache.org/r/32312/#comment125115>

    Should this be non-nullable?



ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql
<https://reviews.apache.org/r/32312/#comment125119>

    Will need these same changes in all the other DB Create.sql scripts, as well as the UpgradeCatalog.



ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql
<https://reviews.apache.org/r/32312/#comment125118>

    This should be non null.


- Alejandro Fernandez


On March 20, 2015, 5:20 p.m., Ivan Kozlov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32312/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 5:20 p.m.)
> 
> 
> Review request for Ambari and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Apart from adding new widget related table definitions in the DDL script for all the
three database types, also update the upgrade catalog for Amabri-2.1.0 to create these tables
on ambari upgrade.
> Tasks:
> Create WidgetEntity and WidgetLayoutEntity.
> Add relationship from both entities to cluster. This will not be used to load widgets
but only to find what StackVersion to use for lookup of stack widgets when requesting WidgetInfo
with layouts.
> Create corresponding DAO objects with unit tests
> Create findById and findBySectionName and findByCluster
> Note: There is no direct relationship between the two.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserWidgetDAO.java PRE-CREATION

>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserWidgetEntity.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutEntity.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutUserWidgetEntity.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutUserWidgetEntityPK.java
PRE-CREATION 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql a06f1d2 
> 
> Diff: https://reviews.apache.org/r/32312/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Kozlov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message