ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Re: Review Request 32297: Add Mahout to HDP Stack
Date Fri, 20 Mar 2015 11:31:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32297/#review77201
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout.py
<https://reviews.apache.org/r/32297/#comment125086>

    Let's create tez_user, maybe we don't need this now but looking into future it might be
useful



ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py
<https://reviews.apache.org/r/32297/#comment125085>

    We should execute this as sudo else it will fail as non-root user.



ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py
<https://reviews.apache.org/r/32297/#comment125087>

    remove_output_dir_cmd = format("fs -rm -r -f /user/{smokeuser}/mahoutsmokeoutput")
    remove_input_dir_cmd = format("fs -rm -r -f /user/{smokeuser}/mahoutsmokeinput")
    
    Can we please change this to
    
    remove_dirs = format("fs -rm -r -f /user/{smokeuser}/mahoutsmokeoutput /user/{smokeuser}/mahoutsmokeinput")
    
    that will make the service check work a bit faster ~15-30 seconds on a hardly loaded cluster


- Andrew Onischuk


On March 20, 2015, 11:15 a.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32297/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 11:15 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-9994
>     https://issues.apache.org/jira/browse/AMBARI-9994
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> .
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/Role.java 59ae001 
>   ambari-server/src/main/java/org/apache/ambari/server/metadata/ActionMetadata.java b9d2d0c

>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml PRE-CREATION

>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json PRE-CREATION

>   ambari-server/src/main/resources/stacks/HDP/2.3/services/MAHOUT/metainfo.xml PRE-CREATION

>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py PRE-CREATION

>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py PRE-CREATION

>   ambari-server/src/test/python/stacks/2.3/configs/default.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32297/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message