ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srimanth Gunturi" <srima...@hortonworks.com>
Subject Re: Review Request 32218: BE: provide 'property_value_attributes' in stacks configuration API
Date Thu, 19 Mar 2015 20:50:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32218/#review77097
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java
<https://reviews.apache.org/r/32218/#comment124952>

    The remove() is for the iterator of dependencies.keySet(). 'dependencies' is a new map
created at the top of method - so should not be shared across threads.


- Srimanth Gunturi


On March 19, 2015, 4:59 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32218/
> -----------------------------------------------------------
> 
> (Updated March 19, 2015, 4:59 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy, Srimanth Gunturi, and Sid Wagle.
> 
> 
> Bugs: AMBARI-10123
>     https://issues.apache.org/jira/browse/AMBARI-10123
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> YARN properties should show up in the API as
> {
>   "href" : "http://c6401:8080/api/v1/stacks/HDP/versions/2.2/services/YARN/configurations/yarn.scheduler.minimum-allocation-mb",
>   "StackConfigurations" : {
>     "final" : "false",
>     "property_description" : "The minimum allocation for every container request",
>     "property_name" : "yarn.scheduler.minimum-allocation-mb",
>     "property_type" : [ ],
>     "property_value" : "512",// Recommended
>     "property_value_attributes": {
>         "type": "int",
>         "minimum": "512",
>         "maximum": "10240",
>         "unit": "MB"
>     },
>     "property_depended_by": [
>       {
>         "property_type": "hive-site",
>         "property_name": "hive.tez.container.size"
>       },
>       {
>         "property_type": "mapred-site",
>         
> property_depends_on in the stack-definition should be transformed inversely to generate
property_depended_by.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
9a7831e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationResponse.java
151ce07 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java
4abf3d2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java
1091bc7 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 4181293

>   ambari-server/src/main/java/org/apache/ambari/server/state/PropertyDependencyInfo.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java e26b48f

>   ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml
7955cb2 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml
3df629d 
>   ambari-server/src/main/resources/properties.json cdb2bd6 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml
94b5304 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
c7878db 
>   ambari-server/src/test/java/org/apache/ambari/server/state/PropertyInfoTest.java e8a2a8d

>   ambari-server/src/test/resources/stacks/HDP/2.0.6/services/YARN/configuration/yarn-site.xml
59b5245 
> 
> Diff: https://reviews.apache.org/r/32218/diff/
> 
> 
> Testing
> -------
> 
> all tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message