ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 32056: Performance: ActionScheduler loads too many objects per Stage iteration
Date Fri, 13 Mar 2015 20:11:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32056/#review76417
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On March 13, 2015, 8:07 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32056/
> -----------------------------------------------------------
> 
> (Updated March 13, 2015, 8:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-10065
>     https://issues.apache.org/jira/browse/AMBARI-10065
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During analysis of a 400 node cluster, the ActionScheduler is loading too many stages,
when it already has a handle to the correct stage.  The entire Request is not needed, when
the code only checks the exclusive flag.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/KdcServerConnectionVerification.java
b7bfef9 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java
8d85d19 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
df75c0c 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
ca169b8 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java ce6a0b8

>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
890ad80 
> 
> Diff: https://reviews.apache.org/r/32056/diff/
> 
> 
> Testing
> -------
> 
> Manual testing + perf testing
> 
> Automated pending
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message