ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 32004: Current Alerts Requests Should Honor Predicate Values For Performance On Large Cluster
Date Fri, 13 Mar 2015 12:03:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32004/#review76355
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On March 12, 2015, 9:44 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32004/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 9:44 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-10052
>     https://issues.apache.org/jira/browse/AMBARI-10052
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When making a request for current alerts, if you want to restrict by an ID, such as the
definition ID, it queries against all entities in the table:
> 
> {{api/v1/clusters/perf400/alerts?fields=*&Alert/definition_id=9}}
> 
> This can cause performance issues in large clusters. We should be using a JPA predicate
here.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AlertCurrentRequest.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java
53e900f 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java d44d2e5

>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity_.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java
ed543f9 
> 
> Diff: https://reviews.apache.org/r/32004/diff/
> 
> 
> Testing
> -------
> 
> Tests running now...
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message