ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jaimin Jetly" <jai...@hortonworks.com>
Subject Re: Review Request 32003: AMBARI-9908. Adds quicklinks and host substitution for Accumulo configs.
Date Thu, 12 Mar 2015 21:49:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32003/#review76289
-----------------------------------------------------------



ambari-web/app/models/quick_links.js
<https://reviews.apache.org/r/32003/#comment123813>

    If Accumulo is having more than one master then this case needs to be handled in the code
at https://git-wip-us.apache.org/repos/asf/ambari/repo?p=ambari.git;a=blob;f=ambari-web/app/views/common/quick_view_link_view.js;h=f9ba942047acca601e418b19087c9a4cdc91637f;hb=HEAD#l184
Otherwise first host instance found for the master will be considered in the regex substitution.
    
    This requires having a way to know which is the current active master.



ambari-web/app/models/service_config.js
<https://reviews.apache.org/r/32003/#comment123809>

    If the expected value is comma-delimited hostname:port then Add instance.zookeeper.host
case over here.


- Jaimin Jetly


On March 12, 2015, 9:34 p.m., Billie Rinaldi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32003/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 9:34 p.m.)
> 
> 
> Review request for Ambari and Jaimin Jetly.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMBARI-9908.  Adds quicklinks and NameNode/ZooKeeper host substitution for Accumulo configs.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/host/details.js 5eac7ca 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 0d2d658 
>   ambari-web/app/mappers/service_metrics_mapper.js 3303369 
>   ambari-web/app/models/quick_links.js 4d686d5 
>   ambari-web/app/models/service_config.js dc7a4e7 
> 
> Diff: https://reviews.apache.org/r/32003/diff/
> 
> 
> Testing
> -------
> 
> I have tried this patch on a local VM.  It may need some adjustments for a multi-node
install.
> 
> 
> Thanks,
> 
> Billie Rinaldi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message