ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jayush Luniya" <jlun...@hortonworks.com>
Subject Re: Review Request 30806: Enable refresh-stack-hash command on windows
Date Wed, 11 Mar 2015 04:36:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30806/#review76041
-----------------------------------------------------------



ambari-server/src/main/python/ambari_server/serverUtils.py
<https://reviews.apache.org/r/30806/#comment123422>

    get_resources_location is not imported causing unit test failures.
    
    ======================================================================
    ERROR: test_refresh_stack_hash (TestAmbariServer.TestAmbariServer)
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/Users/jluniya/merge2/trunk/ambari/ambari-common/src/test/python/mock/mock.py",
line 1199, in patched
        return func(*args, **keywargs)
      File "/Users/jluniya/merge2/trunk/ambari/ambari-server/src/test/python/TestAmbariServer.py",
line 6584, in test_refresh_stack_hash
        refresh_stack_hash(properties)
      File "/Users/jluniya/merge2/trunk/ambari/ambari-server/src/main/python/ambari_server/serverUtils.py",
line 86, in refresh_stack_hash
        resources_location = get_resources_location(properties)
    NameError: global name 'get_resources_location' is not defined
    
    ======================================================================
    ERROR: test_start (TestAmbariServer.TestAmbariServer)
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/Users/jluniya/merge2/trunk/ambari/ambari-common/src/test/python/mock/mock.py",
line 1199, in patched
        return func(*args, **keywargs)
      File "/Users/jluniya/merge2/trunk/ambari/ambari-server/src/test/python/TestAmbariServer.py",
line 3456, in test_start
        _ambari_server_.start(args)
      File "/Users/jluniya/merge2/trunk/ambari/ambari-common/src/main/python/ambari_commons/os_family_impl.py",
line 89, in thunk
        return fn(*args, **kwargs)
      File "/Users/jluniya/merge2/trunk/ambari/ambari-server/src/main/python/ambari-server.py",
line 114, in start
        server_process_main(args)
      File "/Users/jluniya/merge2/trunk/ambari/ambari-server/src/main/python/ambari_server_main.py",
line 307, in server_process_main
        refresh_stack_hash(properties)
      File "/Users/jluniya/merge2/trunk/ambari/ambari-server/src/main/python/ambari_server/serverUtils.py",
line 86, in refresh_stack_hash
        resources_location = get_resources_location(properties)
    NameError: global name 'get_resources_location' is not defined
    
    ----------------------------------------------------------------------
    Ran 234 tests in 6.375s
    
    FAILED (errors=2)
    ----------------------------------------------------------------------
    Failed tests:
    ERROR: test_refresh_stack_hash (TestAmbariServer.TestAmbariServer)
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/Users/jluniya/merge2/trunk/ambari/ambari-common/src/test/python/mock/mock.py",
line 1199, in patched
        return func(*args, **keywargs)
      File "/Users/jluniya/merge2/trunk/ambari/ambari-server/src/test/python/TestAmbariServer.py",
line 6584, in test_refresh_stack_hash
        refresh_stack_hash(properties)
      File "/Users/jluniya/merge2/trunk/ambari/ambari-server/src/main/python/ambari_server/serverUtils.py",
line 86, in refresh_stack_hash
        resources_location = get_resources_location(properties)
    NameError: global name 'get_resources_location' is not defined
    
    ERROR: test_start (TestAmbariServer.TestAmbariServer)
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/Users/jluniya/merge2/trunk/ambari/ambari-common/src/test/python/mock/mock.py",
line 1199, in patched
        return func(*args, **keywargs)
      File "/Users/jluniya/merge2/trunk/ambari/ambari-server/src/test/python/TestAmbariServer.py",
line 3456, in test_start
        _ambari_server_.start(args)
      File "/Users/jluniya/merge2/trunk/ambari/ambari-common/src/main/python/ambari_commons/os_family_impl.py",
line 89, in thunk
        return fn(*args, **kwargs)
      File "/Users/jluniya/merge2/trunk/ambari/ambari-server/src/main/python/ambari-server.py",
line 114, in start
        server_process_main(args)
      File "/Users/jluniya/merge2/trunk/ambari/ambari-server/src/main/python/ambari_server_main.py",
line 307, in server_process_main
        refresh_stack_hash(properties)
      File "/Users/jluniya/merge2/trunk/ambari/ambari-server/src/main/python/ambari_server/serverUtils.py",
line 86, in refresh_stack_hash
        resources_location = get_resources_location(properties)
    NameError: global name 'get_resources_location' is not defined
    
    ----------------------------------------------------------------------


- Jayush Luniya


On March 10, 2015, 10:16 p.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30806/
> -----------------------------------------------------------
> 
> (Updated March 10, 2015, 10:16 p.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, and Jayush Luniya.
> 
> 
> Bugs: AMBARI-9525
>     https://issues.apache.org/jira/browse/AMBARI-9525
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Continued Eugene's work. Added the refresh-stask-hash command to the main script and
to the batch file. Fixed stacks directory retrieval. Fixed resources directory retrieval inconsitencies.
Updated unit tests.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/ambari_commons/os_check.py 39d8202310dcb0e1afc0e4e79ac39800fbf51cc5

>   ambari-server/src/main/python/ambari-server.py 22ab70f274bb944566746bfb89e06f4bf3f5df8f

>   ambari-server/src/main/python/ambari_server/dbConfiguration.py 9962a5d36a3c0742d3bc8494fed0c0b76efc0f6e

>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py c92fd9c105b5505066082edcd9acaa9e02302706

>   ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py 2d3996e17208b0bbe81004b1a6ac91358f9d9ba2

>   ambari-server/src/main/python/ambari_server/serverConfiguration.py f73e75c21ecc5cc871876a41b0ec2dcffb89b2b0

>   ambari-server/src/main/python/ambari_server/serverSetup.py 1c6dbbcae28a803d9e55cb381377017fc5a04d90

>   ambari-server/src/main/python/ambari_server/serverUtils.py 199fada6742a8cc439b20a02067d9980e8ffe7ee

>   ambari-server/src/main/python/ambari_server_main.py d20a9cd7b369e53a509f55c0062d1ccf3d8fb1d2

>   ambari-server/src/main/windows/ambari-server.ps1 92f5186cbbde668db717c3ceef6ffa36c9e490f2

>   ambari-server/src/test/python/TestAmbariServer.py dcea3c67bd35e6091e1f640d7fe84b8f55c16e32

>   ambari-server/src/test/python/TestOSCheck.py d030c525dbd47ff956205f8df06148259ab406f8

>   ambari-server/src/test/python/TestResourceFilesKeeper.py 88cf13758547c406ea7510a52f1424cee1b3b810

>   ambari-server/src/test/python/host_scripts/TestAlertDiskSpace.py 8194bba30a51fc8601df54d6b29942336be78982

> 
> Diff: https://reviews.apache.org/r/30806/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> ran ambari-server refresh-stack-hash -> ok
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message