ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 31898: SLES secured cluster has alerts for Yarn and Storm
Date Tue, 10 Mar 2015 18:26:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31898/#review75915
-----------------------------------------------------------



ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py
<https://reviews.apache.org/r/31898/#comment123238>

    coockie -> cookie
    
    Also, can we just make this a uuid instead? I think that 
    
    `/var/lib/ambari-agent/data/tmp/cookies/0730d6e7-25b5-437e-888f-19208c3fbcca`
    
    looks cleaner than 
    
    `/var/lib/ambari-agent/data/tmp/cookies/cookie0730d6e7-25b5-437e-888f-19208c3fbcca`



ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py
<https://reviews.apache.org/r/31898/#comment123240>

    Move to a `finally` block?



ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py
<https://reviews.apache.org/r/31898/#comment123241>

    aconfig -> ambari_config



ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py
<https://reviews.apache.org/r/31898/#comment123245>

    This doesn't seem like it should be something managed by the stack hooks. Why not just
have the web_alert create the directory if it doesn't exist? Or just have ambari-agent create
the directory on startup (like it does for other directories).


- Jonathan Hurley


On March 10, 2015, 1:40 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31898/
> -----------------------------------------------------------
> 
> (Updated March 10, 2015, 1:40 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-10009
>     https://issues.apache.org/jira/browse/AMBARI-10009
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> After enabling security alerts appeared for Yarn and Storm. See attached files for details.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py d7a833e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py
c90a55c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
7f85428 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
b6d2ba2 
>   ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py
f606130 
> 
> Diff: https://reviews.apache.org/r/31898/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message