ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Re: Review Request 31752: ambari-sudo.sh needs full path, install fails if JDK is not installed
Date Thu, 05 Mar 2015 14:08:43 GMT


> On March 5, 2015, 1:15 p.m., Nate Cole wrote:
> > Seems like we should be abstracting somehow - maybe with an ExecuteSudo or something
that takes the same exact arguments as Execute, but does all this sudo voodoo.
> 
> Jonathan Hurley wrote:
>     Agreed; why is the separate script necessary? I even thought that the existing Execute
resource took a `sudo=true` parameter.
> 
> Andrew Onischuk wrote:
>     Guys we have Execute with sudo=True argument. This thing on lower level below this
Execute.

What I'm talking about is that the bug message fails due to tar error, it doesn't even execute
ambari-sudo.sh 

tar -xf ... && ambari-sudo.sh ...
tar: Unexpected EOF in archive
first one fails

I don't understand how this fix can anyhow fix the problem. 

Also I don't see much purpose of doing this. Ambari-sudo is always in $PATH, which is set
in ambari-env.sh and is inherited by the child processes.
If this doesn't fix anything I think it's looks nicer with short path in task logs.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31752/#review75325
-----------------------------------------------------------


On March 5, 2015, 12:59 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31752/
> -----------------------------------------------------------
> 
> (Updated March 5, 2015, 12:59 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-9938
>     https://issues.apache.org/jira/browse/AMBARI-9938
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When HDP is installed on a host without JDK, the before-install hook will attempt to
install JDK if it is not present. However, this fails because ambari-sudo.sh needs the fully
qualified path to the script.
> 
> ```
> Execution of 'mkdir -p /var/lib/ambari-agent/data/tmp/jdk && cd /var/lib/ambari-agent/data/tmp/jdk
&& tar -xf /var/lib/ambari-agent/data/tmp/AMBARI-artifacts//jdk-7u67-linux-x64.tar.gz
&& ambari-sudo.sh cp -r /var/lib/ambari-agent/data/tmp/jdk/* /usr/jdk64' returned
2.
> [3/4/15, 12:58:13 PM] Alejandro Fernandez: tar: Unexpected EOF in archive
> ```
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/ambari_commons/constants.py b823b31 
>   ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py b6f4821 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 396b9d2

>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py 7d0afc7 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 36c942e 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 8a79701

>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 54ca083 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 21cefae 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 1e4142f 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py e24ff8d 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8aa4871 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 9153a84 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 5230196 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 8d388ab 
>   ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py
e038ddf 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 990eac8 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_drpc_server.py d5afb42 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 3ef45ad 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_rest_api_service.py 64a4662

>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor.py 26089fb 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py 549c5fc

>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py d23114a 
>   ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py b1d9888 
> 
> Diff: https://reviews.apache.org/r/31752/diff/
> 
> 
> Testing
> -------
> 
> Waiting for unit test results.
> 
> Local tests passed,
> ----------------------------------------------------------------------
> Total run:609
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message