ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 31683: RU: query for UpgradeItem is taking too long on large upgrades
Date Tue, 03 Mar 2015 15:57:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31683/#review74967
-----------------------------------------------------------

Ship it!



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java
<https://reviews.apache.org/r/31683/#comment121849>

    Should you clear this cache manually after toResource(...)? I know that since this is
scoped to the method, it should be up for collection to the GC, but with this much data in
there, maybe it should be expressly cleared to indicate that it's not to be held onto?



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
<https://reviews.apache.org/r/31683/#comment121846>

    This is some structure! I understand that making it a NamedQuery would mess up the formatting
and make it totally unreadable. How about just making it a static string so that we don't
have to keep building it?



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandStatusSummaryDTO.java
<https://reviews.apache.org/r/31683/#comment121847>

    These might not be Longs on some databases. Make them Number instead?


- Jonathan Hurley


On March 3, 2015, 10:45 a.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31683/
> -----------------------------------------------------------
> 
> (Updated March 3, 2015, 10:45 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9897
>     https://issues.apache.org/jira/browse/AMBARI-9897
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Added a "Summary DTO" that will get all the stages' task statuses in one call to the
DB, indexed by stage.  This is used instead of iterating, and re-iterating several times over
stages/tasks for a request.
> * Most notable, on large clusters we end up with 1000s of stages and tasks.  All that
iterating was consuming up to 2 minutes for the full upgrade/upgrade_group/upgrade_item/task
tree.  It's now down to about 5s (not great, but I'll take it).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java
3a84529 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java
e55897c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java
a0ff3d9 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
9a56e2b 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
a55f383 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandStatusSummaryDTO.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 76df049

>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java
6252d4e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java
1d80f47 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
ef4bd82 
> 
> Diff: https://reviews.apache.org/r/31683/diff/
> 
> 
> Testing
> -------
> 
> Manual testing of cluster install + upgrade to make sure both RU-related and non-RU-related
tasks showed the correct numbers.
> 
> Tests run: 2763, Failures: 0, Errors: 0, Skipped: 15
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:34.415s
> [INFO] Finished at: Tue Mar 03 10:41:42 EST 2015
> [INFO] Final Memory: 32M/337M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message