ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 31630: Alert Targets Should Have a Directive to Overwrite Existing On Creation
Date Mon, 02 Mar 2015 21:17:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31630/#review74820
-----------------------------------------------------------

Ship it!



ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertDefResourceDefinition.java
<https://reviews.apache.org/r/31630/#comment121596>

    Use _



ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertTargetResourceDefinition.java
<https://reviews.apache.org/r/31630/#comment121595>

    Mixing camelCase with under_score_case.  Should be consistent with _ to match the way
we do other json.


- Nate Cole


On March 2, 2015, 1:22 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31630/
> -----------------------------------------------------------
> 
> (Updated March 2, 2015, 1:22 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9874
>     https://issues.apache.org/jira/browse/AMBARI-9874
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Alert targets should include a directive to allow overwriting an existing target with
brand new data.
> 
> POST http://localhost:8080/api/v1/alert_targets?overwriteExisting=true
> {
>   "AlertTarget": {
>     "name": "Simple",
>     "description": "This target does not work",
>     "notification_type": "FOO",
>     "groups": [1,2,3]
>   }
> }
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertDefResourceDefinition.java
66e5a83 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertTargetResourceDefinition.java
5e5079e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
886348b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
19beb01 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java
2d08a7a 
> 
> Diff: https://reviews.apache.org/r/31630/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message